@mmalerba , I have raised a new PR here. The old one seems to be messed up while rebasing. Also, I have added here the extra check for disabled thingy. It might be because of this missing condition those internal google tests were failing ?

CARETAKER NOTE: There are still 18 projects with failing tests. I think they're most likely just bad tests, where people expected the current behavior because it was the current behavior, rather than because it actually makes sense. But we will need to go through and fix those before we can land this

@mistrykaran91 I looked into one of the tests and the root of the problem seemed to be that a change event was fired even when the value didn't change. I think this is similar to what you were getting at with adding the disabled check, but it seems that's not the only scenario where it can erroneously emit a change.

@mistrykaran91 I looked into one of the tests and the root of the problem seemed to be that a change event was fired even when the value didn't change. I think this is similar to what you were getting at with adding the disabled check, but it seems that's not the only scenario where it can erroneously emit a change.

Ok, Not sure how can I reproduce this one but i'll take a look and try to debug where it's failing

@mmalerba : I have added one empty check before firing _change event, may be that should fix the issue ?